dataUriHtmlHeader should consistent with WEBVIEW_DATA_URL_PREFIX otherwise load from html string not work

juancarlospaco / webgui

Web Technologies based Crossplatform GUI Framework with Dark theme

https://juancarlospaco.github.io/webgui

MIT License

140 stars 8 forks source link

Closed bung87 closed 1 year ago

bung87 commented 2 years ago

juancarlospaco commented 2 years ago

I do not understand the Bug report, but Pull Requests welcome, maybe it is even faster than explaining it to me... 🙂

bung87 commented 2 years ago

isDataURL = (strncmp(webview_url, WEBVIEW_DATA_URL_PREFIX,
                         strlen(WEBVIEW_DATA_URL_PREFIX)) == 0);

will be fails in current implementation.

bung87 commented 2 years ago

data:text/html, compare to data:text/html;....

juancarlospaco commented 2 years ago

Sorry I dont get it, if you understand it maybe just send the Pull Request and will be merged.

juancarlospaco commented 2 years ago

Feel free to send PR @bung87 I dont fully understand your problem sorry, but I can merge the fix. 🙂