Icon assignment feedback

[nsonnad]

Hello Juan! Good work on this story, which is very sad and distressing indeed. Glad GitHub worked out for getting the page up and working. Here are some of my thoughts:

Story

This is certainly good choice of data story, one where the numbers can do a lot of work to help explain the issue.

In terms of what could be changed, I wanted more context for some of these numbers. You note that the report says the rise in murders "might be a consequence of the social emergency caused by the pandemic," but how does that work? Why would the pandemic cause such a dramatic rise in this specific hate crime, and are there any other potential explanations? I think the change is too big to ignore, going from ~20 to ~80. The same goes for the regions: you tell us that it is highest in the Caribbean region, but that is not so meaningful to readers unless you explain it a bit further, perhaps by saying as you told the class that this has historically been the case (and, again, for what reason)?

In general, data is just numbers and we usually need to contextualize it for people. But you have a good story here, it just needs a tiny bit more detail.

Design/Code

I would have liked to see a couple things different here:

• The page should not go to full width on large screens; it makes it very hard to read the text, and you should limit the width so that it creates a more narrow column. You can achieve this by wrapping the entire contents of the page in a div and setting the max-width on it, as I did in this example: https://github.com/data-fall-2021/assignment-1-examples/tree/main/example-project
• Your HTML has a lot of mismatched tags that shouldn't be there like, for example, these closing tags that repeat throughout: https://github.com/juanddsj/project1/blob/main/index.html#L152-L155. Make sure that for each open tag there is a corresponding closing tag. You can check whether there are mismatched tags by using tools like the HTML validator. You also have some cases of a <div class="icon"> containing another one, which will lead to issues with your CSS.
• Your icon section should match the width of the text, whereas yours just goes to 50%.

I copied your project and made a few changes that I think solve most of these problems. I wanted to share it with you so you can see what I did, which I think is easier than explaining it. You can see my version here and the code for it here.

Great work overall, particularly on the story aspect, feel free to reach out if you have any questions!

[juanddsj]

Hello Nikhil. Thank you for this feed back. This is an article I would like to keep working on, your suggestions about where to give more detail about the context give me a route to follow to work on a next version.

About the code, I see the version with the changes you made and that I think it looks better aligned centered. For some reason that now I think it was those tags or the div you mentioned, I was having trouble with getting the size I wanted for the image and the icons, cause I wanted the icons to be very small and the image to be large. But anytime I would change the site of the first it would affect the size of the other.

Thank you again. See you in class.