search

juanep97 / iop4

IOP4, the Interactive Optical Photo-Polarimetric Python Pipeline.
https://juanep97.github.io/iop4/
BSD 3-Clause "New" or "Revised" License
5 stars 2 forks source link

Enable automatic code checks? #118

Open morcuended opened 3 months ago

morcuended commented 3 months ago

Do we want to enable automatic checks for format, syntax and linting? It would require to make a lot of modifications and cleanup of the code

juanep97 commented 3 months ago

I would not enable that, except for perhaps new committed lines.

morcuended commented 3 months ago

I think it could be done for new committed lines. Either activating the precommit hook at the developer level (when you push a commit, it will be formatted, linted, etc). Another way would be to enable the precommit hook in CI but only for diff lines (I think this is also possible).

In any case, although it is not critical, IMO the whole code would benefit from a standard format check.