No RPM packages? - Githubissues

juanfont / headscale

An open source, self-hosted implementation of the Tailscale control server

BSD 3-Clause "New" or "Revised" License

20.84k stars 1.15k forks source link

No RPM packages? #1367

Open fuomag9 opened 1 year ago

fuomag9 commented 1 year ago

Bug description

Rpm packages were present in https://github.com/juanfont/headscale/releases/tag/v0.22.0-alpha2, they are not anymore

Is this intended?

abosaad11 commented 1 year ago

The rpm packages are still there.

fuomag9 commented 1 year ago

The rpm packages are still there.

Where? There are no RPM packages in the latest release...

jonathanspw commented 1 year ago

https://copr.fedorainfracloud.org/coprs/jonathanspw/headscale/

fuomag9 commented 1 year ago

https://copr.fedorainfracloud.org/coprs/jonathanspw/headscale/

Thank you! Is that official?

https://github.com/juanfont/headscale/issues/1341#issuecomment-1514391252 did not plan to move it to a repo for what I understood (I very much welcome the change!)

jonathanspw commented 1 year ago

Not sure if they will end up calling it official or not but @kradalby held back the RPMs in https://github.com/juanfont/headscale/pull/1297 specifically because I was building these.

juanfont commented 1 year ago

@fuomag9 I reckon @jonathanspw's plan is to make them official into Fedora/CentOS/RHEL. Is that correct?

kradalby commented 1 year ago

@jonathanspw pinging @juanfont question, would you consider trying to upstream them to the official repos?

jonathanspw commented 1 year ago

@jonathanspw pinging @juanfont question, would you consider trying to upstream them to the official repos?

I could put them in the official repos but I think given how quickly headscale is pushing to newer and newer Go versions constantly it would result in Fedora releases getting outdated quite fast. COPR works around this by letting me build it with custom verions of Go as needed.

kradalby commented 1 year ago

Sounds reasonable, I think we should do two things:

it would be great if you could make a PR to link to this in the docs and on the webpage
create a template for the release text in go releaser which mentiones this so that we post it on every release

gbraad commented 1 year ago

@jonathanspw the problem is that the package can not be used with a version check. The RPM version returns:

$ headscale version
dev

which is non-usable value.

github-actions[bot] commented 6 months ago

This issue is stale because it has been open for 90 days with no activity.

jonathanspw commented 6 months ago

This is not stale.

github-actions[bot] commented 3 months ago

This issue is stale because it has been open for 90 days with no activity.

jonathanspw commented 3 months ago

Still not stale.

FreedomBen commented 2 months ago

I got here after grepping the git log and finding b12a167fa243bed6d6703a235b299ce1c6f679f8 .

Would it be accurate then to summarize the current state as this?:

RPMs are no longing being built and attached to the github release page
RPMs are still being built but are going to this COPR repo: https://copr.fedorainfracloud.org/coprs/jonathanspw/headscale/

COPR link: https://copr.fedorainfracloud.org/coprs/jonathanspw/headscale/ Github of the COPR build: https://github.com/jonathanspw/headscale-rpm

jonathanspw commented 2 months ago

I got here after grepping the git log and finding b12a167 .

Would it be accurate then to summarize the current state as this?:
1. RPMs are no longing being built and attached to the github release page

2. RPMs are still being built but are going to this COPR repo:  https://copr.fedorainfracloud.org/coprs/jonathanspw/headscale/
COPR link: https://copr.fedorainfracloud.org/coprs/jonathanspw/headscale/ Github of the COPR build: https://github.com/jonathanspw/headscale-rpm

Correct.

For EPEL the builds will likely remain COPR-only (due to the Go version required for building). For Fedora I'll revisit the idea of putting them in base Fedora repos once 0.23 is stable.