[Bug] Hostname changes are not reflected

Proxymiity commented 1 week ago

Is this a support request?

[X] This is not a support request

Is there an existing issue for this?

[X] I have searched the existing issues

Current Behavior

Changing the hostname of a node is not reflected on headscale.

Using tailscale set --hostname hello still keeps the hostname that the node originally came with.

Expected Behavior

Changing the hostname of a node on the node itself should reflect it on the node list in headscale. This is the current behavior with 0.22.3.

Steps To Reproduce

Start 0.23.0 (either upgraded from 0.22.3 or a fresh install)
Register a new node on the server
Note its hostname
Change the hostname. On desktop, tailscale set --hostname something. On mobile, it is located in the settings of the app.
Note that the hostname stayed the same

Environment

- OS: Docker 27.0.3 (Host: Debian 12.6)
- Headscale version: 0.23.0
- Tailscale version: 1.74.1 (ccd6bf2f4ee6421c23789b64e6e63c2ccbe87e08)
- Tailscale version (phone): iOS 18.0 // TS 1.74.0 (TestFlight beta 101.74.0)

Runtime environment

[X] Headscale is behind a (reverse) proxy
[X] Headscale runs in a container

Anything else?

No response

msarsha commented 6 days ago

Having the same issue. restarting both node and server does not help. @kradalby want to point me to where this should be implemented? I could have a look and check if do-able for me.

kradalby commented 5 days ago

@msarsha It would probably be in this function: https://github.com/juanfont/headscale/blob/main/hscontrol/poll.go#L454

You probably want to look at the logic in Rename node to ensure there is no collision, I have not had too much time to think about this yet, but will look closer if you post a PR.

If you dont have time, let me know and I'll look at it later.

juanfont / headscale