Fix error handing when Ruby/scss-lint missing

juanfran / gulp-scss-lint

Gulp plugin to lint scss files with `scss-lint`

113 stars 33 forks source link

Fix error handing when Ruby/scss-lint missing #81

Closed peterkelly closed 6 years ago

peterkelly commented 7 years ago

fixes #75

The "Fatal undefined" error message is being reported instead of "You need to have Ruby and scss-lint gem installed" due to the misspelling of a variable in the lint function in index.js. This has shown up in other projects that depend on gulp-scss-lint, e.g. https://github.com/ionic-team/ionic/issues/10358

juanfran commented 7 years ago

Thank you very much for this and sorry for the delay.

I think this is great but I would prefer to continue using gutil.PluginError. So I did this https://github.com/juanfran/gulp-scss-lint/commit/9f9ea3a90206ae5ccc070fcd28b967d99f94496b that I think is fixed the problem. if is it ok to you I will close the issue and the PR.

thanks!