search

juanfran / gulp-scss-lint

Gulp plugin to lint scss files with `scss-lint`
113 stars 33 forks source link

Plugin fails silently if Ruby is not installed #9

Closed jbalbes closed 9 years ago

jbalbes commented 10 years ago

The title says it all.

I added this to a project not realizing that it required Ruby. The task ran without error, and did not have any complaints about my scss. Naturally suspicious of anything that works right the first time, I double checked my set up. This is when I spotted the Ruby requirement in the readme. This was surprising, because I do not have Ruby installed on my machine.

It would be better if the plugin failed with an error and clear message, rather than silently in this situation.

juanfran commented 10 years ago

Did you install the scss-lint gem? The plugin doesn't check if you have Ruby, the plugin checks if you have scss-lint installed and if you don't the plugin thrown an error. Ruby is mandatory to install the scss-lint gem.

jbalbes commented 10 years ago

I do not have the gem or Ruby installed. The project that I am working on does not require Ruby, and I would rather not add it as a dependency just to get an scss linter. I realize that this plugin will not work without it, but it should fail with a good and loud error message, rather than silently.

juanfran commented 10 years ago

Without ruby and scss-lint the plugin throws me this exception. 

Error in plugin 'gulp-scss-lint': You need to have Ruby and scss-lint gem installed

What operating system you are using?

jbalbes commented 10 years ago

Windows 8.1

juanfran commented 10 years ago

I just tested the plugin on windows 8.1 and throws an error when I don't have ruby installed but works as you say when the plugin does not receive any scss file.

davidkassa commented 10 years ago

The error I received without ruby/the gem installed is below.Server 2012 R2

events.js:72 throw er; // Unhandled 'error' event ^ Error: Error code 1 at C:\CX\cx-cui\node_modules\gulp-scss-lint\src\index.js:59:32 at ChildProcess.exithandler (child_process.js:641:7) at ChildProcess.EventEmitter.emit (events.js:98:17) at maybeClose (child_process.js:743:16) at Socket. (child_process.js:956:11) at Socket.EventEmitter.emit (events.js:95:17) at Pipe.close (net.js:465:12)

juanfran commented 10 years ago

Do you have the latest version of the plugin?

davidkassa commented 10 years ago

Sorry for not providing that info. Version ^0.1.0.

On Sep 16, 2014, at 4:02 PM, Juanfran notifications@github.com wrote:

Do you have the latest version of the plugin?

— Reply to this email directly or view it on GitHub.

juanfran commented 10 years ago

Should work well in the latest version, 0.1.3