search

juanfranblanco / vscode-solidity

Visual Studio Code language support extension for Solidity smart contracts in Ethereum https://marketplace.visualstudio.com/items?itemName=JuanBlanco.solidity
MIT License
902 stars 193 forks source link

Multiple Workspaces: Linting doesn't work with multi-root workspaces #237

Open CodeForcer opened 3 years ago

CodeForcer commented 3 years ago

Although it styles the code and performs the compilation, this extension doesn't seem to lint properly when using multi-root workspaces with either Solhint or Solium.

It works fine when you open a single project folder, just not multi-root

juanfranblanco commented 3 years ago

Yes, correct. All the extension works around a single workspace. So it is not just linting.

sebastiantf commented 3 years ago

It seems the linter doesn't pickup .solhint.json configs inside a subdir. Is it configurable in the extension settings? It would be nice to let the extension pickup .solhint.json inside a subdir, or configure it where to look for .solhint.json in a monorepo.

iboxgithub commented 3 years ago

same issue for me, I guess it is linked to this: https://forum.openzeppelin.com/t/trouble-importing-openzeppelin-contracts-into-vs-code/5230/7

markokhman commented 2 years ago

Was anybody able to solve this ever? Quite annoying behavior...

iboxgithub commented 2 years ago

nope

juanfranblanco commented 2 years ago

I am looking at it now

iboxgithub commented 2 years ago

nice 😄 thanks!

juanfranblanco commented 2 years ago

It is checked in now.

@sebastiantf regarding subdirectories and mono repos, if it is at root the file will work as usual (single workspace), although yes with multiple workspaces the root is in each workspace, that will need copy and paste. The solution will be to have an absolute location for the config file, which will add complications in the future for web support.