build: bundle extension (>40 MB -> 26 MB)

juanfranblanco / vscode-solidity

Visual Studio Code language support extension for Solidity smart contracts in Ethereum https://marketplace.visualstudio.com/items?itemName=JuanBlanco.solidity

MIT License

892 stars 191 forks source link

build: bundle extension (>40 MB -> 26 MB) #418

Closed llllvvuu closed 1 year ago

llllvvuu commented 1 year ago

resolves microsoft's warnings that it spits out when you vsce pack an unbundled extension:

https://aka.ms/vscode-bundle-extension

juanfranblanco commented 1 year ago

Hi,

I missed this, I will need to test it. Although one of the reasons I do not bundle it is so anyone can inspect the code. Thoughts? @llllvvuu

llllvvuu commented 1 year ago

Hey @juanfranblanco , ultimately I couldn't get it to work so I've abandoned the PR for now.

But if it did work, then I would say that code inspection could be solved with source maps.

juanfranblanco commented 1 year ago

Ah good point! I always worry about any type of MITM attack.