search

juanfranblanco / vscode-solidity

Visual Studio Code language support extension for Solidity smart contracts in Ethereum https://marketplace.visualstudio.com/items?itemName=JuanBlanco.solidity
MIT License
904 stars 194 forks source link

Solium Dependency Update #53

Closed nikitaeverywhere closed 6 years ago

nikitaeverywhere commented 6 years ago

Hello! Thank you for writing a great plugin for VSCode.

While Solium is v1.1.5 in master branch, it is still v0.5.5 in vscode-solidity.

Will you accept pull request updating the dependency? Are there any critical parts of the plugin that may be affected?

Thank you!

antogh commented 6 years ago

Any advice on how to upgrade the Solium version in this VS Code solidity extension? I get a lot of nonsense warning and errors on some sources, would like to use the new solium version but don't know how to upgrade. Thanks

nikitaeverywhere commented 6 years ago

@antogh looks like they abandoned this project. Maybe we should consider forking it. Anyone from maintainers?

duaraghav8 commented 6 years ago

Hey guys, I'm the maintainer of Solium. Although I don't have much knowledge about this extension itself, you can try resolving your problem the same way https://github.com/beaugunderson/vscode-solidity-extended/issues/3 deals with it.

nikitaeverywhere commented 6 years ago

@duaraghav8, thank you! Doing so will most likely work, but we need to get some feedback from vscode-solidity maintainers first. They have a couple of PRs with no feedback yet given and that's why I assume the project is abandoned. Anyone from maintainers? @juanfranblanco?

antogh commented 6 years ago

Thank you @duaraghav8

I tried the other extension but I didnt find a way to change the compiler version there When I tried I was very tired (working hard on short deadlines) so I asked on that repo how to do it, https://github.com/beaugunderson/vscode-solidity-extended/issues/8 no answer so far

Overall the other extension seems less documented and with much less settings to customize the environment. I prefer this extension.

@juanfranblanco did an excellent job, he also has a great reputation, I dont think he abbandoned this project. I hope to get an answer from him to fix this issue. Shouldnt be difficult, after all solium is just an external reference to this extension, should be a matter to upgrade that reference. I confess I tried to force this upgrade manually but failed so far, I changed the package.json reference to solium, in a win10 machine it is located here %USERPROFILE%.vscode\extensions\JuanBlanco.solidity-0.0.31\package.json and I changed the solium folder with the newest from @duaraghav8 repo , in the same win10 machine this is the folder where the vscode extension stores solium %USERPROFILE%.vscode\extensions\JuanBlanco.solidity-0.0.31\node_modules\solium

unfortunately something went wrong, VS Code was erroring at start saying the extension crashed.

Again I did it tired and in a hurry, maybe I missed something, if someone else want to try and in case of success update this thread.

I have also the problem that github email notifications sometime are not fired, I missed the last couple of messages here, I have to do manual polling to check the issues I am involved in... 😡

juanfranblanco commented 6 years ago

No the project is not abandoned I just get no damn notifications. I will do upgrades this weekend for everything.

Please drop by in Gitter on either Nethereum or Vscode if you dont get any answers.

antogh commented 6 years ago

Hi @juanfranblanco thanks , I am big fan of you and your project, glad to hear you and know the project is still alive (had little doubts about it) I was almost going to ping you on twitter but was afraid to disturb you. Good that you noticed this issue on your own.

So I am not alone with this missed GH notification problem... we maybe should open another issue with GH ...

I noticed that after changing the destination email for GH notifications to a gmail account (had different provider before) the reception rate has improved, maybe it can help...

Cheers

juanfranblanco commented 6 years ago

Yes. I have actually just done that, let's see how it goes. Feel free to ping me anytime in twitter or Nethereum https://gitter.im/Nethereum/Nethereum. I am always there providing support.

nikitaeverywhere commented 6 years ago

Thank you very much @juanfranblanco! I appreciate your work and use your solidity plugin on a daily basis.

juanfranblanco commented 6 years ago

Closing this, as it is upgraded now.

antogh commented 6 years ago

Hi @juanfranblanco saw the upgrade this morning I got the new solium in your extension (dind't even notice the upgrade, all was done silently without requesting my approval to update)

However I have a problem with this upgrade, now every linter warning or error is causing an annoying popup to appear in the bottom right corner , how do I disable it? I was ok with errors just in the "problems" windows that I show when I want but these continuos notification popup are really annoying and distracting when coding

juanfranblanco commented 6 years ago

That might be due to the Emit issue as it is not fully finished in solium. I'll disable it (remove it)

antogh commented 6 years ago

ok thanks, have a look at this to feel my pain vscode popups

juanfranblanco commented 6 years ago

New version published

antogh commented 6 years ago

Thanks, I see no more popups , but again didnt tell vs code to update your extension nor I was notified it was happening , it seems all happening in background silently... robots starts to decide instead of humans :)