search

juanfranblanco / vscode-solidity

Visual Studio Code language support extension for Solidity smart contracts in Ethereum https://marketplace.visualstudio.com/items?itemName=JuanBlanco.solidity
MIT License
892 stars 190 forks source link

Solidity Linter no longer shows Problems #69

Closed ghost closed 6 years ago

ghost commented 6 years ago

It worked fine a week/2 weeks ago, but right now the linter isn't working at all.

vscode1 vscode2

juanfranblanco commented 6 years ago

Hi, have you installed any of the "extended" solidity extensions? As they are causing problems.

ghost commented 6 years ago

I do not have solidity extended installed, although I did try it out but I have uninstalled it. I have also tried uninstalling and reinstalling the extension, as well as reinstalling VS Code. I am using windows.

juanfranblanco commented 6 years ago

Did you install it and then this issue happened?

ghost commented 6 years ago

No it was already happening before I installed solidity extension.

juanfranblanco commented 6 years ago

Have you tried to open only the ERC20 folder?

juanfranblanco commented 6 years ago

This is a wild shot btw..

ghost commented 6 years ago

Yes still doesn't work. Could it be something with my windows setup? I did install geth etc recently.

juanfranblanco commented 6 years ago

No geth won't affect this. I am releasing a new version with a higher number. I am thinking something is being left behind that causes this.

(From the extended)

ghost commented 6 years ago

It works fine on my mac, which I just installed VS Code and your extension.

Also, the default does not work with open-zeppelin: // Default directory where the Package Dependency store its contracts, i.e: 'src', 'contracts', or just a blank string '' "solidity.packageDefaultDependenciesContractsDirectory": "contracts",

// Default directory for Packages Dependencies, i.e: 'node_modules', 'lib' "solidity.packageDefaultDependenciesDirectory": "node_modules",

I have to do this in User Settings: "solidity.packageDefaultDependenciesContractsDirectory": "", "solidity.packageDefaultDependenciesDirectory": "",

ghost commented 6 years ago

It turns out in my C:\Users\ricox.vscode\extensions I had:

JuanBlanco.solidity-0.0.42 JuanBlanco.solidity-0.0.43.

2 solidity extensions for some reason. I deleted them and reinstalled and now the linting works!

juanfranblanco commented 6 years ago

@ricochen awesome thanks, great discovery work. I'll raise an issue (or if you want you are welcome) to vscode.

ghost commented 6 years ago

You can raise the issue and tag me!

juanfranblanco commented 6 years ago

Raised as above, it is by design as per comments. See the thread.