search

juanfung / frbca

Other
0 stars 0 forks source link

PV Cost calculation is hard-coded #10

Closed juanfung closed 6 months ago

juanfung commented 8 months ago

Nonstructural costs are discounted relative to base year, but this discounting is hard-coded:

https://github.com/juanfung/frbca/blob/530b79df3cfda489d9a6b0f05d9da6dd33a53da5/R/frbca.R#L96

Similarly, the total cost then adjusts nonstructural costs for maintenance over the life of the building...but again, this is hard-coded (it should be 0.5 * T):

https://github.com/juanfung/frbca/blob/530b79df3cfda489d9a6b0f05d9da6dd33a53da5/R/frbca.R#L97

juanfung commented 6 months ago

Resolved by 2923230

Since we will be using current dollars across all calculations, no need to readjust NS costs (per the first problem above).

PV total calculation is now pv_total = pv_s + pv_ns where pv_ns is calculated separately and is parameterized rather than hard coded