Closed juanfung closed 6 months ago
Resolved by 2923230
Since we will be using current dollars across all calculations, no need to readjust NS costs (per the first problem above).
PV total calculation is now pv_total = pv_s + pv_ns
where pv_ns
is calculated separately and is parameterized rather than hard coded
Nonstructural costs are discounted relative to base year, but this discounting is hard-coded:
https://github.com/juanfung/frbca/blob/530b79df3cfda489d9a6b0f05d9da6dd33a53da5/R/frbca.R#L96
Similarly, the total cost then adjusts nonstructural costs for maintenance over the life of the building...but again, this is hard-coded (it should be 0.5 * T):
https://github.com/juanfung/frbca/blob/530b79df3cfda489d9a6b0f05d9da6dd33a53da5/R/frbca.R#L97