Improve/streamline plot functions

juanfung commented 3 months ago

Current plot functions are kludgey. Needs

[ ] Wrapper to streamline plotting as inputs are the same (same goes for postprocessing code)
[ ] Global plot theme (so this isn't getting done ad hoc with each plot) #14
[ ] Plotting other metrics
[x] EDIT: filtering by model list should actually be by design (intervention); need to update preprocessing to create this column, with plain english names, for easy plotting (as this is getting done ad hoc for plotting from the outputs)

juanfung commented 3 months ago

Update postprocessing functions so that:

[x] Expected input is not entire model name (eg, RCMF-4-baseline-nsfr)
[x] Instead, filter by system, design, and num_stories, with defaults
- system = "RCMF
- design = "baseline-nsfr`
- num_stories = 4

juanfung commented 3 months ago

[x] Rename existing (postprocess|plot)_eal functions to more accurate (postprocess|plot)_eal_by_design, as these function really disaggregate EALs to report bar chart of by loss categories, for a single design
[x] Create new (postprocess|plot)_eal functions to summarize EALs across range of systems and stories
[x] Repeat for (postprocess|plot)_bcr

juanfung commented 3 months ago

EDIT: filtering by model list should actually be by design (intervention); need to update preprocessing to create this column, with plain english names, for easy plotting (as this is getting done ad hoc for plotting from the outputs)

UPDATE: resolved by 3282cae2d99573cf0457bbea35b1216c9e4fe9ed

juanfung commented 3 months ago

[x] Repeat for (postprocess|plot)_bcr

Resolved by b0f54b9, which created separate baseline and sensitivity BCR plots

juanfung commented 3 months ago

[x] Rename existing (postprocess|plot)_eal functions to more accurate (postprocess|plot)_eal_by_design, as these function really disaggregate EALs to report bar chart of by loss categories, for a single design

[x] Create new (postprocess|plot)_eal functions to summarize EALs across range of systems and stories

UPDATE: Resolved by d874a92

Note the plot_eal function is broken down into two functions: one for total EALs across systems (currently a placeholder) and one for disaggregated EALs by loss category (plot_eal_by_loss)

juanfung commented 3 months ago

Update postprocessing functions so that:

[x] Expected input is not entire model name (eg, RCMF-4-baseline-nsfr)

[x] Instead, filter by system, design, and num_stories, with defaults

system = "RCMF

design = "baseline-nsfr`

num_stories = 4

Resolved by b0f54b9 and https://github.com/juanfung/frbca/commit/d874a92f255502b9149d3bcd23af2c7fd807dac6

juanfung commented 3 months ago

[x] Update placeholder plot_eal to plot EALs across multiple systems

juanfung commented 3 months ago

[x] Update placeholder plot_eal to plot EALs across multiple systems

UPDATE: Resolved by d85f9a1

juanfung / frbca

Improve/streamline plot functions #23