search

juanfung / pycge

Other
15 stars 12 forks source link

pycge.py depends on package `dill` #1

Closed juanfung closed 5 years ago

juanfung commented 6 years ago

https://github.com/juanfung/pycge/blob/b2ec400202aaa22ac344e95500eaf0aab1a6b44e/pycge/PyCGE.py#L5

Not generally included with python or anconda. Either:

(1) explicitly state dependency and instructions for installation (one of pip install dill or conda install -c anaconda dill); or

(2) conditionally install it as part of the pycge package.

juanfung commented 6 years ago

For now, this should be handled by setuptools and install_requires in setup.py:

setup(
    ...
    install_requires = ['dill>=X', 'pyomo>=Y'],
    ...
juanfung commented 6 years ago

As tested: dill >=0.2.7.1*

*assuming backward compatibility with future versions of dill