search

juanfung / scpd

0 stars 0 forks source link

The Cholesky function `chol` is no longer part of `Base` #12

Closed juanfung closed 5 years ago

juanfung commented 5 years ago

Should import LinearAlgebra library and use LinearAlgebra.chol. See this warning, e.g., from running script causal-sims.jl:

WARNING: Base.chol is deprecated: it has been moved to the standard library package LinearAlgebra. Add using LinearAlgebra to your imports. in module CausalMixtures in NobileWishart at /home/juanfung/Dropbox/Projects/School choice/scpd/Analyze/CausalMixtures/src/misc_functions.jl

juanfung commented 5 years ago

Fixed by 8509294938a0ae478d35674994bbc41dac6dedfb

juanfung commented 5 years ago

Another instance of deprecation warning:

WARNING: Base.chol is deprecated: it has been moved to the standard library package LinearAlgebra. Add using LinearAlgebra to your imports. in sample_prior_theta! at /home/juanfung/Dropbox/Projects/School choice/scpd/Analyze/CausalMixtures/src/sampler_functions.jl

Should be addressed by importing LinearAlgebra in above commit.