juanfung / scpd

0 stars 0 forks source link

Error: method `Distributions.sample` does not exist #8

Closed juanfung closed 5 years ago

juanfung commented 5 years ago

In causal-hedonic.jl, line 54: f = Distributions.sample(["a", "b"], n) throws an error.

The code is supposed to sample n elements with replacement from ["a", "b"].

It appears this is now part of package StatsBase, so...

  1. Update CausalMixtures.jl to load package StatsBase
  2. change line 54 of causal-hedonic.jl
  3. check rest of code for uses of Distributions.sample
juanfung commented 5 years ago

Points 1 and 2 addressed by df20d804fd34ad3fc3b00e118482636c26a9924c

juanfung commented 5 years ago

Reviewed code in CausalMixtures/src as well as scripts in Analyze and did not find any other uses of Distributions.sample. Closing for now.