search

juanigallo / notion-next-blog

notion-next-blog-xi.vercel.app
23 stars 7 forks source link

Move name and logo to environment variables #2

Open juanigallo opened 1 year ago

juanigallo commented 1 year ago

In the actual state of the code, inside the Nav component, there are two hardcoded labels (the square and the H1 with the text "Juani Gallo"). This is not good because we want this project to be as easy to setup as possible so a good idea is to move that information to an environment variable

faisalamin001 commented 1 year ago

Can you please share logo file (png,svg), I will add it in .env variable file

juanigallo commented 1 year ago

In the current state of the code, the logo is just code. Feel free to add two env variables (one for the name, and one for the logo) and only render them in the Nav component if they are not empty

faisalamin001 commented 1 year ago

Please give me permission to push the code or make me an editor for future collaboration. Thanks

notion-next-blog % git push origin -u env-branch remote: Permission to juanigallo/notion-next-blog.git denied to faisalamin001. fatal: unable to access 'https://github.com/juanigallo/notion-next-blog.git/': The requested URL returned error: 403