juanii / OnePIF

KeePass 2.x plugin to import 1Password Interchange Format (1pif) files.
GNU General Public License v2.0
14 stars 0 forks source link

Import failure with empty sections part #2

Closed thge closed 5 years ago

thge commented 5 years ago

My exported pif file form 1Password for Windows 4.6.2.626 contained one entry with an empty sections entry. This leads to an error in the import function Object reference not set to an instance of object and the import aborts. After deleting the "sections":[{"title":"","name":""}] part the import runs without problems.

{"uuid":"1CE4ADEB831141869D18F7D77B85EC36","updatedAt":1455218641,"securityLevel":"SL5","openContents":{"scope":"Never","tags":["WLAN"]},"contentsHash":"4c6d72c","title":"WLAN Hotspot","txTimestamp":1455218641,"createdAt":1415831265,"typ\ eName":"webforms.WebForm","secureContents":{"fields":[{"value":"uuuu","name":"username","type":"T","designation":"username"},{"value":"pppp","name":"password","type":"P","designation":"password"}],"passwordHistory":[{"value":"ppp2","time\ ":1455218641}],"notesPlain":"some notes","sections":[{"title":"","name":""}]}}

Thanks for your work.

juanii commented 5 years ago

Thank you very much for your feedback! It's already fixed and released. This makes it very clear I have to work on error handling and write tests, though I don't think I'll write any tests for now :)

Regards