juanje / cookbook-redmine

Chef's Cookbook for installing Redmine
25 stars 21 forks source link

Redmine version bump #3

Closed tuxinaut closed 12 years ago

tuxinaut commented 12 years ago

Now it works

juanje commented 12 years ago

Thanks for the patch! :-)

I guess you've removed the rmagick and rails gems because it get installed with the bundle install, right? I also guess the gems rake, rack and probably mysql will be installed by bundler. In that case it could be a good idea to remove them.

Could you check it and update the commit? And also do you mind to leave the extra newline at the recipe?, I put two newlines between groups of tasks to see them more clear.

Update the current commit and I'll test it later.

I usually update the commit of my pull-request by doing:

# do the changes
$ git add [files changed]
$ git commit --amend
# save it
$ git pull -f

The commit of this pull-request will be updated with the new one and I'll be able to merge it. Just in case you didn't know it so you don't have to create another pull-request.

Thanks again for your contributions.

juanje commented 12 years ago

I see a few commits and some changes doesn't match, but the merged change does work, so I did the merge on my local branch and pushed back to the repo. I pushed your changes as a single commit. And you as the commit's author, of course.

I did test the changes and works fine for me, thanks for your help :-)

I have some cleaning up comming and some improvements so stay tune if you like to test them and contribute more ;-)

tuxinaut commented 12 years ago

I have seen the changes and test these in the next days. Many thanks for these great cookbook