Closed telemaco closed 11 years ago
Hi @telemaco, thanks for the PR :smile:
Although, I see the benefits of your contributions I'd rather prefer you to split the PR. The Vagrantfile
, Berfksfile
, Gemfile
, .gitignore
and the cookbook's name at the ` metadata.rb file were missing and are specific of this project/cookbook, but the bootstrap scripts are not.
I mean, they aren't config file to be used by the cookbok or part of the cookbook itself. Actually it could be a separate mini project with may be used in any cookbook. But it's not specific of this cookbook in particular.
I prefer not to ship external code logic with the cookbook.
Please, create a new PR with the cookbook related files or change this one removing the bootstrap script stuff. I'm not saying that isn't good stuff, but I just don't feel it should be shipped here.
Thanks
Ok. I've added Vagrant and Berkshelf in other PR :)
You can close this PR when you want
As long as the refactor code is already in another PR I close this PR to clean up a bit.
Thanks.
Include: