search

juanjoDiaz / serverless-plugin-warmup

Keep your lambdas warm during winter. ♨
MIT License
1.11k stars 115 forks source link

Alternative event bus #326

Closed brandon-constratum closed 1 year ago

brandon-constratum commented 2 years ago

I've run out of Event Rules for deploying new warmups via the plugin, is it possible to choose another Event Bus for the rules?

I've applied for AWS quota limit increase from 300 rules but they have yet to approve it.

Edit: I have also tried using the serverless eventBridge type but i get an error when adding the eventBus field Serverless: at 'custom.warmup.default.events[0]': unrecognized property 'eventBus'

juanjoDiaz commented 2 years ago

Hi @brandon-constratum ,

How many lambda projects do you have? And how many warmers do you have per project? 300 sounds like a lot of warmers... Maybe some consolidation could help?

At the moment this plugin only supports scheduled events as triggers. How do you propose that the event bus works?

Maybe eventBridge could be a solution. But I need to research. I don't fully understand the difference between scheduled events and eventBridge events.

brandon-constratum commented 2 years ago

Thanks for the reply,

Yeah 300 is a lot of warmers, we currently are using serverless as each "app" is an api so we have about 80 of those but then they are deployed across 3-4 stages all with warmers, so it adds up quickly, we are considering dropping warmers for our development stage which will help.

as far as i can tell an event bus almost acts like a folder for events which can be customised.

i think scheduled events and event bridge events are the same thing but you can just specify which bus they go on as they go on "default" without it.

juanjoDiaz commented 2 years ago

Hi @brandon-constratum ,

I've created a branch adding experimental support for eventBridge. Unfortunately, I don't have time to test it.

You could install it using npm install https://github.com/juanjoDiaz/serverless-plugin-warmup.git#add_event_bridge_support and test it out.

If you do, please let me know how it goes 🙂

juanjoDiaz commented 1 year ago

Hi @brandon-constratum ,

I assume that you never tried the branch? Did you find a workaround to your issue?

brandon-constratum commented 1 year ago

@juanjoDiaz hey! Sorry, I didn't get around to it, it was a very busy time for me and I think by the time you were able to get to it (which I appreciate very much) AWS had increased our quota limit so we were able to continue as is and since then we have culled a lot of our exisiting versions and dev/testing stages that we no longer needed so we have ample event rules now.