search

juanjux / evil-search-highlight-persist

Emacs minor mode to highlight search results in all the buffeer until you clear them or make another, like Vim hlsearch option.
GNU General Public License v2.0
21 stars 11 forks source link

When `evil-search-module` is `evil-search` then `SPC s c` doesn't work #6

Open tuhdo opened 9 years ago

tuhdo commented 9 years ago

Original issue here: https://github.com/syl20bnr/spacemacs/issues/1326

You have quite many users using your package now.

juanjux commented 9 years ago

I'm an emacs newbie, what should "SPC s c" do? If I disable evil-search and do "SPC s" emacs just says "SPC s is not defined".

tuhdo commented 9 years ago

evil-search-highlight-persist-remove-all is bound to SPC s c, so it is expected to clear all highlighting. However, if you set evil-search-module to 'evil-search then the highlighting clear doesn't work anymore.

juanjux commented 9 years ago

Mmmm, by default evil-search-highlight-persist-remove-all is bound to C-x SPC. I've tried to set evil-search-module to evil-search and C-x SPC still works for me.

jonathanj commented 9 years ago

@juanjux Out of interest did you restart Emacs after changing evil-search-module? I found that changing the setting alone did not have any effect until Emacs was restarted. I guess Evil has to be reloaded or something?

When using evil-search the highlighting appears to be different from the normal isearch highlighting, which is usually how you can tell which one is currently in use. (And you can also press <up> to go through previous search history from the search minibuffer.)

jonathanj commented 9 years ago

Conversation about this issue has recently come up again and I noticed there was no reply to my suggestion as to how to reproduce it. (Which has effectively helped others to reproduce it.)

Do you have any better idea why changing the search module might break this functionality?

juanjux commented 9 years ago

Hi! The problem is that I'm not using Emacs anymore, I went back to pure (Neo)Vim, so if you want to fork an maintain this go ahead!