Open BelCo94 opened 2 years ago
Hi @BelCo94 , sorry for the late reply, I will try to look at this soon.
@BelCo94 I can confirm the bug, looking into it.
@BelCo94 fixed now, I will push again 6.0.40 images, but as the fix is present in this version onwards, upgrades from a previous version like 6.0.38 will need to be done manually as you did.
@juanluisbaptiste Did you push that to anywhere? Seems the images 6.0.37 and 6.0.40 still have this error.
Idea: what about copying
${OTRS_ROOT}/current_version
to ${OTRS_CONFIG_DIR}/current_version
if this does not exist?I could make a PR for that if this is wanted.
(sorry for that confusion, this is not actually needed)
Ps. Oh no!
# docker run --entrypoint="" juanluisbaptiste/znuny:latest grep current_version /functions.sh
local current_version_file="${OTRS_CONFIG_DIR}/current_version"
if [ -e ${current_version_file} ] && [ ${OTRS_UPGRADE} != "yes" ]; then
current_version=$(cat ${current_version_file})
print_info "Current installed OTRS version: \e[1;31m$current_version\e[1;0m"
check_version ${current_version} ${new_version}
print_info "Doing minor version upgrade from \e[${OTRS_ASCII_COLOR_BLUE}m${current_version}\e[0m to \e[${OTRS_ASCII_COLOR_RED}m${new_version}\e[0m"
echo ${new_version} > ${current_version_file}
current_version=$(cat ${OTRS_ROOT}/RELEASE |grep VERSION|cut -d'=' -f2)
current_version="${current_version## }"
echo "${current_version}" > "${OTRS_CONFIG_DIR}/current_version"
seems this is the only image this has been fixed
While testing issue #123 I found that previous fix was wrong, and it ended up overwriting the contents of /opt/otrs/Kernel/current_version
after a minor version upgrade. I just pushed an updated 6.0.40 image.
Sorry for the noise, I did some commit rebasing last night, I wasn't aware that these messages were going to be added again.
Files and modules are not upgraded when minor version upgrading, according to the instructions from README.md.
Image versions: 6.0.37 and 6.0.38
Upgrade is successful only if I manually create a file "current_version" in volume mounted to
/opt/otrs/Kernel/
and put information about current version in it (6.0.37). After upgrade file contains new version (6.0.38).I think the problem is the file "current_version" is being created and checked in different places by function
load_defaults()
inotrs/functions.sh
:line 254:
local current_version_file="${OTRS_CONFIG_DIR}/current_version"
line 273:echo ${current_version} > ${OTRS_ROOT}/current_version
docker-compose.yml
.env
logs