search

juanluisbaptiste / docker-otrs

The unofficial Znuny/OTRS Ticketing System docker image
https://www.juanbaptiste.tech/category/otrs
GNU Lesser General Public License v3.0
172 stars 101 forks source link

Make otrs ftp url be configurable #74

Closed glmars closed 4 years ago

glmars commented 4 years ago

Added new env variable OTRS_DOWNLOAD_MIRROR to support configuring local mirror to load OTRS

fixes #70

glmars commented 4 years ago

Please, do not merge. Need some more changes.

glmars commented 4 years ago

Ready for merge now! There were some problems with defaults for OTRS_DOWNLOAD_MIRROR.

juanluisbaptiste commented 4 years ago

Hi,

This is not the way to do it, all functionality must be contained within the container image and be able to set it up at runtime, not at compile time as you are doing.

Please take a look at run.sh and functions.sh to see how other variables are handled, in bash.

juanluisbaptiste commented 4 years ago

Sorry, you are right, this is not a feature that needs to be enable at container runtime because OTRS download is only done when building the image.

I'll take a closer look at the diff to see if there are any other observations.

juanluisbaptiste commented 4 years ago

Hi,

Please see this comment done on the diff, and add the respective documentation about this new feature to the README file.

Squash all changes into a one single commit and we are ready.

juanluisbaptiste commented 4 years ago

Also when I pulled your PR it also for some reason pulled the CHANGELOG commit that is already merged, so make sure it doesn't part of this PR.

glmars commented 4 years ago

Sorry, you are right, this is not a feature that needs to be enable at container runtime because OTRS download is only done when building the image.

Yes, I am worried about creating an image. I can’t create the otrs image in Russia now because the IP address (178.63.12.4) of ftp.otrs.org is blocked in our country by mistake 😄

But I also checked the file check_otrs_latest_version.sh and found some lines from ftp.otrs.org. As I understand it, this is a managing script, but can also be changed to a configurable version if necessary (by separate PR). :wink:

juanluisbaptiste commented 4 years ago

But I also checked the file check_otrs_latest_version.sh and found some lines from ftp.otrs.org. As I understand it, this is a managing script, but can also be changed to a configurable version if necessary (by separate PR). wink

That script is a work in progress to automate image rebuild upon new OTRS release, but its currently not finished (testing it) so don't bother about it for now.

PS: I edited your previous comment by mistake when trying to quote it, sorry about that.

juanluisbaptiste commented 4 years ago

Hi,

Are you going to finish this PR or should I go ahead and close it ?

glmars commented 4 years ago

Hi, I'm sorry, I'm a little busy in the last days, but I'm going to add some commits to this PR ;)

juanluisbaptiste commented 4 years ago

As it seems you don't have the time to finish this I will close it. Feel free to reopen it if you have the time to work on it.