search

juanluisbaptiste / docker-otrs

The unofficial Znuny/OTRS Ticketing System docker image
https://www.juanbaptiste.tech/category/otrs
GNU Lesser General Public License v3.0
175 stars 104 forks source link

rotate the "real" backups #98

Closed rdxmb closed 4 years ago

rdxmb commented 4 years ago

close https://github.com/juanluisbaptiste/docker-otrs/issues/96

rdxmb commented 4 years ago

ping @juanluisbaptiste

juanluisbaptiste commented 4 years ago

Hi @rdxmb , I'm sorry for the late reply. Thanks for the PR, I guess this is a fair workaround, but I don't think this is the best way to fix this issue. Probable a better option would be to have a separate process to delete old backups instead of doing it when the backup process runs, it will work for now.

rdxmb commented 4 years ago

Thanks, @juanluisbaptiste !

Probable a better option would be to have a separate process to delete old backups instead of doing it when the backup process runs

IMO it's the best to run this after a successful backup. If the delete-Job is separate and deletes old dumps, while the backup-job does not run (e.g. in the case of a full /tmp in the container (which is /var/lib/ on the host)) you would not have a backup after ${BACKUP_ROTATION_DAYS} days.

juanluisbaptiste commented 4 years ago

Good point :+1: