juanluisbaptiste / docker-postfix

Simple SMTP relay docker image.
GNU General Public License v3.0
336 stars 166 forks source link

feat: Add support to load username from file #60

Closed sudosauer closed 3 years ago

sudosauer commented 3 years ago

Other services like Traefik and pgadmin have this functionality. It can help simplify compose files so that all your services can load email from a file rather than some with email from file and some from environment or hardcoded.

juanluisbaptiste commented 3 years ago

Hi @pedanticprogrammer , thank you for the PR.

As per the new versioning scheme, could you please amend the commit message to start with "feat:" so images get tagged with the proper version ?

TY

sudosauer commented 3 years ago

No problem, changed the message.

juanluisbaptiste commented 3 years ago

I'm sorry if I wasn't clear, I meant on the git commit message, not on the PR.

juanluisbaptiste commented 3 years ago

If yóu are not sure how to do it, follow these instructions:

git commit --amend
(editor will open up, fix the commit message)
git push -f
sudosauer commented 3 years ago

Oh, sorry! Still learning. Is it all good now?

juanluisbaptiste commented 3 years ago

No, not really, you pushed new commits instead of amending the first one. The idea was to fix the commit message of the initial commit, using the instructions I put on a later post. With git commit --amend you can fix the commit message of the last commit you did, but as that commit was already pushed it needs to be for pushed (git push -f).

Now you need to undo the last two commits, you could try resetting your branch to the first commit you did like this:

  1. Make a copy of your working directory (the docker-postfix directory.)
  2. Hard reset the last two commits: git reset --hard HEAD~2
  3. Force push commits: git push -f
  4. Make sure with git log that HEAD now points to the initial commit with hash aafc176.
sudosauer commented 3 years ago

Okay went back to the original commit, and amended the message. Hopefully i got it right this time. Sorry for the trouble and thank you for your patience!

juanluisbaptiste commented 3 years ago

It seems ok now !

juanluisbaptiste commented 3 years ago

Merged, thanks !