juanluisbaptiste / docker-postfix

Simple SMTP relay docker image.
GNU General Public License v3.0
336 stars 166 forks source link

feat: Add ENV option to enable subject line logging #68 #69

Closed linucksrox closed 2 years ago

linucksrox commented 3 years ago

Creating a Pull Request

We use github actions to do automatic semantic versioning, so please use the following nomenclature for the commit message according to the type of change:

Description of the change

Resolves issue #68 This simply allows you to pass LOG_SUBJECT=yes as an environment variable in order to enable outputting the subject line in the logs.

Motivation and Context

I like to see the subject line in the logs to help identify messages.

How Has This Been Tested?

Since this change affects a file that also is related to SMTP_HEADER_TAG, I tested 4 scenarios:

  1. setting neither SMTP_HEADER_TAG or LOG_SUBJECT
  2. setting only SMTP_HEADER_TAG but not LOG_SUBJECT
  3. setting only LOG_SUBJECT=yes but not SMTP_HEADER_TAG
  4. setting both SMTP_HEADER_TAG and LOG_SUBJECT=yes

Types of Changes

Checklist:

And lastly, many thanks for taking your time to help us improve this project !

juanluisbaptiste commented 2 years ago

Hi @linucksrox I'm sorry for the late reply, I will try to review this this week.

juanluisbaptiste commented 2 years ago

@linucksrox merged, apologies for the delay.

linucksrox commented 2 years ago

@juanluisbaptiste Thanks!