juanmanzanero / fastest-lap

Fastest-lap is a vehicle dynamics simulator. It can be used to understand vehicle dynamics, to learn about driving techniques, to design car prototypes, or just for fun!

MIT License

575 stars 43 forks source link

Argument CMAKE_BUILD_TYPE optional during cmake build v2 #14

Closed kktse closed 2 years ago

kktse commented 2 years ago

Background

13 managed to make CMAKE_BUILD_TYPE optional for Mac and Linux, but broke Windows builds. Fixing what I broke.

This PR uses a different approach, defaulting CMAKE_BUILD_TYPE to Release, as opposed to fancy inline checking.

Testing

Still builds on my Linux machine. I also ran CI on my fork for Windows, https://github.com/kktse/fastest-lap/pull/2

Checklist

Before submitting a pull request, make sure you satisfy all of the following points:

[x] Give as much detail as possible on what is included within the pull request
[x] Make sure that new additions are not already present in the project
[ ] ~~If it contains source code, comply with the coding guidelines~~
[ ] ~~Add new tests for new features~~
[x] Run and pass the tests using GitHub's workflows

juanmanzanero commented 2 years ago

Superb. Thank you very much :)