search

juanmc2005 / SimilarityLearning

Similarity Learning applied to Speaker Verification and Semantic Textual Similarity
12 stars 7 forks source link

Further Refactor Trainers #4

Closed juanmc2005 closed 5 years ago

juanmc2005 commented 5 years ago

Currently the trainers have more code in common than I'm confortable with. Try to make them as small as possible, without losing the needed flexibility

hbredin commented 5 years ago

Did you have a look at how I handle this in pyannote.audio with the base pyannote.audio.train.Trainer class?

I am not saying this is the way to go, just one possible way of doing it.

juanmc2005 commented 5 years ago

@hbredin I looked at it very quickly a few days ago. I'll take a look at how it's structured in more detail. I'm sure there's something I might be able to borrow

juanmc2005 commented 5 years ago

Note: Prioritizing this issue in order to ease the development of #6