juanmc2005 / diart

A python package to build AI-powered real-time audio applications
https://diart.readthedocs.io
MIT License
1.09k stars 91 forks source link

[joss][docs] - Collected Docs suggestions #176

Closed sneakers-the-rat closed 1 year ago

sneakers-the-rat commented 1 year ago

Just going to gather all my thoughts on the docs in this issue rather than raising separate issues

Part of: https://github.com/openjournals/joss-reviews/issues/5266

juanmc2005 commented 1 year ago

@sneakers-the-rat not sure I understand the last two points. Could you expand on those?

sneakers-the-rat commented 1 year ago

Yes! So for 3, eg here in the optimization part, I don't know what the database tables that would create are - in general when you have some sort of data structure that's produced or consumed by a package it's good to give some kind of abbreviated example except when it's a standard (eg. it seems like .rttm is a standard so you wouldn't necessarily need to provide an example of it, but even providing a 5-line head of one would be useful).

For 4, there are decent "how to use this" docs in the README, but I couldn't find any docs about "here is how the package is structured" or how individual classes/functions worked. Some of the classes/functions already have docstrings, so it would be pretty nice to make that work you've done doing internal API-level documentation visible by using something like sphinx and autodoc to create a documentation website.

so eg here's an old package of mine's documentation - https://docs.auto-pi-lot.com/en/latest/ it has a user guide which is "how to use this" stuff, but then individual classes have documentation like this one which is generated from its docstring .

I offered to help out with further questions on docs in case you have never set up a sphinx/readthedocs site before, so we could use this issue to chat if you'd like to pursue that - like i said not all packaged need a docs site, and the README does get the point across for basic usage, but imo it's a really good practice for long-term maintenance to document how the internals of the package work.

juanmc2005 commented 1 year ago

@sneakers-the-rat I updated the README and created a documentation page with all the information you suggested. Everything will be accessible with the next release (v0.9).

Concerning the data structures created, I think it would probably be better to write a tutorial on tuning that could be hosted in readthedocs (see #210).