juanmcasillas / gopro2gpx

Parse the gpmd stream for GOPRO moov track (MP4) and extract the GPS info into a GPX (and kml) file.
GNU General Public License v3.0
181 stars 50 forks source link

Add GoPro Hilights support #44

Closed JimmyS83 closed 7 months ago

JimmyS83 commented 9 months ago

I was inspired by https://github.com/imaplt/gopro-highlights https://github.com/icegoogles/GoPro-Highlight-Parser

and having new camera, I want to try to extract also Hiligts form camera. This code works pretty well, but it would welcome some cosmetics / polishing. I was unable to get current gmpf parser work for extracting HLMT data, so I use another parsing from Highlight-Parser.

However, if no Hilights stored in GoPro records, this another parsing method triggers warning from fourCC Manage() method. I was unable to resolve this at time of creating PR. Otherwise, it should work pretty good - at least it works on my GoPro8 files. Tested with files with and without Hilights, it creates txt summary of timstamps, as well add WPT to the gpx file with timestamps as well.. Its safe to use that way, I didnt find any drawbacks, processing this GPX via Dashware, and seeing Hilights in map quickly with timestamp I found VERY usefull..

Feel free to polish this, but I think this is a good feature, so although I dont have much time to better adapt to the current gmpf parser, I submit this PR for potentiall interest of others / or you.