juanparadox / react-tachyons

A React.JS + Tachyons component library.
11 stars 0 forks source link

Testing #47

Open juanparadox opened 7 years ago

juanparadox commented 7 years ago

It's time we start write some test for our components! I'm going to start a simple test with a set of components (articlelists) just to get things going. I'll be following the standards and recommendations found here: https://facebook.github.io/jest/

If you have any other idea for tests or how to approach them, let me know!

anater commented 7 years ago

I have no strong opinions on testing. I find them really cumbersome but have little experience using them.

anater commented 7 years ago

Although one thought I had has to do with #26. We intended to go back and import the tachyons modules separately. That’ll be a pain to do at this point though lol.

Could you also shed some more light on why we’d want to write tests for simple components? I wonder because I know testing is most suitable when you have modules that are reused by other modules and so you need to make sure changes don’t cascade improperly. In our case, unless the markup was exactly the same, the components aren’t dependent on other components (yet).

juanparadox commented 7 years ago

I am suggesting testing more so to guarantee that all of our components are rendering. They would be simple test, but it will help in the case someone else were to contribute. We can hold off on this and put our focus on the actual site that will play home to the documentation.