juaryimami / leaderboard-project

Leader board project is a simple API development educational website built with JAVA SCRIPT HTML CSS.
MIT License
0 stars 0 forks source link

Leader board practice project with webpack and git flow #1

Closed juaryimami closed 1 year ago

juaryimami commented 1 year ago

In this project:-


juaryimami commented 1 year ago

kindly sir your are blocking my approval. I used git flow release branch isn't it part of git flow. it is not fair. Making my development branch to default is optional. it is up to me.

Abenezer-Tilahun commented 1 year ago

Hello @juaryimami for this project you have to follow the Git-flow, I am not blocking your approval brother .For future Lead board project activity you should create pull request from the feature branch to development branch(default branch) , After you finished Lead board project you will merged the result to main branch. I am not here discourage you but it helps you for future project, Please update it .

juaryimami commented 1 year ago

git flow release start '0.1.0' isn't it a good git flow practice bro.

juaryimami commented 1 year ago

after making updates the I merge to my devleopment ranch by git flow release finish '0.1.0' this is what i do.

Abenezer-Tilahun commented 1 year ago

Hello @juaryimami I understand you brother and you are right. but it's stated in one of the project requirement that why i suggested you to make changes but at this moment request for reviewer and the reviewer will approve it ,still in the future i recommend you to follow the project requirement .

juaryimami commented 1 year ago

ok thanks bro