search

juba / questionr

R package to make surveys processing easier
https://juba.github.io/questionr/
81 stars 17 forks source link

Levels recoding not working #131

Closed bassam-abulnoor closed 2 years ago

bassam-abulnoor commented 2 years ago

After 0.7.6 update levels recoding function not working giving the error message "%>% unexpected character". When I rolled back to earlier version it returned back to normal. I really like your package and think it's super useful thanks.

juba commented 2 years ago

Thanks !

You're talking about the levels recoding addin, right ?

I can't seem to reproduce your issue right now. Do you load the tidyverse or forcats package before calling the addin ? Could you describe when the error message appears exactly ?

bassam-abulnoor commented 2 years ago

Thanks for your comment. Yes exactly I'm talking about the addin and the error occurs in the final step of code production and tidyverse is loaded before that. I'm attaching a photo with the error hope it helps. The variable I'm recoding is binary numeric and has some missing values. The error disappears when I revert back to 0.7.5 again thanks for your effort. image

juba commented 2 years ago

Oh, I see ! You were trying to recode a numeric variable I guess ? There was an error in the generated forcats recoding code in this case.

Could you please install the latest development version to see if the issue is fixed for you ?

remotes::install_github("juba/questionr")

Thanks for taking the time to report the issue and to provide details allowing me to fix it (I hope !).

bassam-abulnoor commented 2 years ago

Yes it's fixed! thanks a lot for your efforts and fast response. A different issue I encountered now that may be related but this time with the factors ordering addin. If you try to order a numeric variable the code works but an error is displayed in the check panel don't know if this is intentional or not thought it might be helpful to report.

A

Can't thank you enough for this package it's literally a life saver. My most used r package after tidyverse and I'm very glad that I finally have the chance to thank you.

juba commented 2 years ago

Thanks for the kind words !

You're right, there was also an error when reordering a numeric variable with forcats, I didn't test this use case. This should be fixed now in the development version, thanks again for reporting the issue.

I'll close this issue for now, but don't hesitate to reopen it if needed.

bassam-abulnoor commented 2 years ago

Thanks again :)