search

juba / rainette

R implementation of the Reinert text clustering method
https://juba.github.io/rainette/
53 stars 7 forks source link

Rewrite C++ code without RcppEigen #6

Closed privefl closed 4 years ago

privefl commented 4 years ago

It is actually a bit faster now too.

The dev code and benchmark I used: https://gist.github.com/privefl/9820f2152a9a0de46f3a7367d0fea813

juba commented 4 years ago

Thanks a lot !

Is it ok if I add you in authors@R like this ?

person("Florian", "Privé", email="florian.prive.21@gmail.com", role="aut")

privefl commented 4 years ago

Yes, it is okay, but I don't think this deserves "aut"; "ctb" would be more than fine.

juba commented 4 years ago

Well then, "ctb" it is !

Thanks a lot again.