search

juba / rmdformats

HTML output formats for RMarkdown documents
723 stars 140 forks source link

jQuery UI an unused dependency of readthedown #130

Closed sciatro closed 2 years ago

sciatro commented 2 years ago

jQuery UI is included as a dependency of rmdformats::readthedown.

I noticed in the devtools coverage report of my knitted html it was consistently 90+% unutilized with all of the utilization looking like it occurred at initialization.

After seeing that steady usage report despite reasonably substantial interaction with the page I started to manually remove it from my knitted results and I'm yet to notice any js errors or UI issues.

I've tested with tabs and pills, with code folding, and shrinking my window so the navigation folds up, and using the lightbox (e.g. #128) and all seem to work. Is it possible that jQuery UI is not being used by readthedown at this point?

Sorry for the flood of issues. Thanks again for your hard work and willingness to entertain these.

juba commented 2 years ago

Yes, I think you're right. I included the jQueryUI dependency because it is present in the html_document() default RMarkdown template, but after digging a little bit it seems it is only used there for the tocify jQuery plugin, which is not used in rmdformats.

So I removed the dependency, we'll see if it breaks something else 😅

Thanks for your report !