search

juba / robservable

Observable notebooks as R htmlwidgets
https://juba.github.io/robservable/
163 stars 11 forks source link

figure out how to support FileAttachment #41

Open timelyportfolio opened 3 years ago

timelyportfolio commented 3 years ago

FileAttachment does not seem to work. Explore possibility of adding support for it.

juba commented 3 years ago

No, I think your error is linked to the fact that Object.fromEntries is not supported by the RStudio underlying web engine (a chromium version which is a bit outdated). It should work if you open it in a more recent browser, or if you run it in VSCode for example.

The latest RStudio version embeds chromium v69, and Object.fromEntries is supported starting with chromium v73.

juba commented 3 years ago

Yes, but I think the user agent string here (Chrome/69.0.3496.128) means that the underlying chromium version is the same as in stable. Did you try to open the result in a browser to see if it works ?

hrbrmstr commented 3 years ago

ah! (i'm daft) yep. i see what you mean now. it's fine in Edge/Chrome.

and i think i got messed up b/c i hadn't tried it with and without a notebook that used FileAttachment.

apologies for messing up the issue. I'll delete the previous thread entries.

timelyportfolio commented 3 years ago

@hrbrmstr @juba maybe we should open another issue to build some plot examples and discuss some of these complicating issues. Bob, not unexpected, we are thinking the same thing :)

juba commented 3 years ago

@timelyportfolio I wanted to take a look at this issue but I'm not sure what you mean precisely about the lack of support of FileAttachment ?