jubako / arx

Store files and directory in an archive. Like tar, but faster and with direct random access.
MIT License
151 stars 2 forks source link

Please add a license file #90

Closed mbridon closed 3 days ago

mbridon commented 3 days ago

I just tried rust2rpm to package arx for Fedora, and it complained about there not being a license file:

$ rust2rpm arx
Downloading arx-0.3.2.crate: 100%|███████████████████████████████████████████████████████████████████████████████████| 26.5k/26.5k [00:00<00:00, 223kB/s]
ERROR: No license files were detected. In almost all cases, this is an issue
       with the upstream project that should be reported.
• To temporarily ignore this issue, use the '--ignore-missing-license-files' /
  '-I' flag - for example, when manually including license files from the
  upstream project, or for test builds.

I think you need to declare the crate as having a license and a license file? :thinking:

mbridon commented 3 days ago

Right: https://doc.rust-lang.org/cargo/reference/manifest.html#the-license-and-license-file-fields

mgautierfr commented 3 days ago

There is already https://github.com/jubako/arx/blob/main/LICENSE-MIT

mbridon commented 3 days ago

Yes, but it is not declared in Cargo.toml as an actual license file, hence #91 :wink: