search

jubatus / jubatus-installer

Install Script of Jubatus
18 stars 17 forks source link

Eliminate most LD_LIBRARY_PATH from install.sh. #33

Open gwtnb opened 9 years ago

gwtnb commented 9 years ago

Use rpath to find libraries instead of LD_LIBRARY_PATH. Why LD_RUN_PATH is not used is that ld.gold does not recognize LD_RUN_PATH for now. https://sourceware.org/bugzilla/show_bug.cgi?id=13764

https://github.com/jubatus/jubatus/issues/943

kmaehashi commented 9 years ago

I'll confirm this. We need to add this to the packaging tool too.

Is it OK to close #32 once this got merged?

kmaehashi commented 9 years ago

Specifying -p option cause error on apr-utils installation.

$ ./install.sh -p /home/jubatus/rpath-test
... snip ...
/usr/bin/install -c -m 644 ./lib/expat.h /home/jubatus/rpath-test/include/apr-1
make[1]: Leaving directory `/home/jubatus/Development/jubatus-installer/download/apr-util-1.5.4/xml/expat'
/bin/sh /home/jubatus/rpath-test/build-1/libtool --mode=install /usr/bin/install -c -m 755 libaprutil-1.la /home/jubatus/rpath-test/lib
libtool: install: error: cannot install `libaprutil-1.la' to a directory not ending in /home/jubatus/local/lib
make: *** [install] Error 1
gwtnb commented 9 years ago

Such error does not appear on my environment. Could you re-run with -p after removing your download directory?

gwtnb commented 9 years ago

./waf --checkall seems to ignore LINKFLAGS which is specified at ./waf configure.