search

jubatus / jubatus-installer

Install Script of Jubatus
18 stars 17 forks source link

Suppress subprocess's stdout #55

Closed rimms closed 6 years ago

rimms commented 7 years ago

Fixes https://github.com/jubatus/jubatus-installer/issues/30

kmaehashi commented 7 years ago

I think it's too silent; users cannot tell if it is woking or not. Minimal progress report for each step ("Downloading xxx", "Installing xxx", "This may take several minutes", etc.) is needed.

rimms commented 7 years ago

I added messages for some steps.

How about this?

Downloading archives
Installing dependencies
Installing jubatus-mpio
Installing jubatus-msgpack-rpc
Installing jubatus_core
Installing jubatus

//=============================================================//
//                                                             //
//   _________         ___                                     //
//   \____   _|       | /             ___I_I___                //
//       |  |         | |             \__^ ^__/        ____    //
//       |  |         | | ___    ___  __ | |          / __/    //
//       |  | |-|  |-|| |/   \  /   \| | | | |^|  |^|| (__     //
//       |  | | |  | ||    ^  ||  ^    | | | | |  | | \__ \    //
//       |  | | \_/  ||    O  ||  O    | | |_| \_/  | ___) |   //
//       |  |  \__/|_||_|\___/  \___/|_| |__/ \__/|_| \___/    //
//       | /                                                   //
//      / /                                                    //
//     |/                                                      //
//                                                             //
//=============================================================//
              Jubatus 1.0.3 Installation Completed!

   .. snip ..

  Have fun!  -- Jubatus Team
kmaehashi commented 7 years ago

Still under review...

So far I found that Ctrl-C cannot stop build after applying this PR:

$ ./install.sh
Downloading archives
Installing dependencies    <- I type Ctrl-C during this step
^CInstalling jubatus-mpio  <- and the build does not stop...
rimms commented 6 years ago

Fixed via https://github.com/jubatus/jubatus-installer/pull/65