jubatus / jubatus_core

Jubatus algorithm component
GNU Lesser General Public License v2.1
20 stars 29 forks source link

datum_to_fv_converter.combination_feature_string may fails #385

Closed kazuki closed 5 years ago

kazuki commented 7 years ago

I ran the test of jubatus-core 1.0.5 in the i686 (python manylinux1 environment), and the test failed as follows.

[ RUN      ] datum_to_fv_converter.combination_feature_string
../jubatus/core/fv_converter/datum_to_fv_converter_test.cpp:607: Failure                     
Value of: feature                 
  Actual: { ("name$xyz@space#bin/bin", 1), ("name$abc@space#bin/bin", 1), ("title$foo@space#bin/bin", 1), ("title$bar@space#bin/bin", 1), ("name$xyz@space#bin/bin&title$foo@space#bin/bin/add", 2), ("name$xyz@space#bin/bin&title$bar@space#bin/bin/add", 2), ("name$abc@space#bin/bin&tit
le$foo@space#bin/bin/add", 2), ("name$abc@space#bin/bin&title$bar@space#bin/bin/add", 2), ("title$foo@space#bin/bin&title$bar@space#bin/bin/mul", 1) }
Expected: expected                                                                           
Which is: { ("name$xyz@space#bin/bin", 1), ("name$abc@space#bin/bin", 1), ("title$bar@space#bin/bin", 1), ("title$foo@space#bin/bin", 1), ("name$xyz@space#bin/bin&title$bar@space#bin/bin/add", 2), ("name$xyz@space#bin/bin&title$foo@space#bin/bin/add", 2), ("name$abc@space#bin/bin&tit
le$bar@space#bin/bin/add", 2), ("name$abc@space#bin/bin&title$foo@space#bin/bin/add", 2), ("title$bar@space#bin/bin&title$foo@space#bin/bin/mul", 1) }

splitted token order is unstable because jubatus::core::fv_converter::counter uses unordered_map.

TravisCI fortuitously passed this test.

kazuki commented 7 years ago

Maybe, this issue causes model incompatibility between other architecture/stdc++impl.

stale[bot] commented 5 years ago

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

stale[bot] commented 5 years ago

Closing this issue after a prolonged period of inactivity. Please feel free to create a new issue or re-open it if you need.