Implement similar_row_from_*_and_{score,rate} to recommender

jubatus / jubatus_core

Jubatus algorithm component

GNU Lesser General Public License v2.1

20 stars 29 forks source link

Implement similar_row_from_*_and_{score,rate} to recommender #387

Closed rimms closed 7 years ago

rimms commented 7 years ago

Refs. https://github.com/jubatus/jubatus/issues/1100

TkrUdagawa commented 7 years ago

When I tested similar_row_from_id_and_rate using jubatus server and queried with negative rate value, I got lots of data points. I don't think this is expected result. We need to validate the input parameter.

My test codes are here. I also printed out the intermediate value of calculation(rate, result of std::ceil, ret_num).

rimms commented 7 years ago

Thanks. I implemented validation to rate.

TkrUdagawa commented 7 years ago

LGTM