search

juberti / cryptex

IETF Internet-Draft for Completely Encrypting RTP Header Extensions and Contributing Sources
Other
3 stars 4 forks source link

[Robert Wilton] Mix 1 and 2 bytes #94

Closed murillo128 closed 2 years ago

murillo128 commented 2 years ago

Only one trivial comment:

If the packet contains solely one-byte extension ids, the 16-bit RTP header extension tag MUST be set to 0xC0DE to indicate that the encryption has been applied, and the one-byte framing is being used. If the packet contains only two-byte extension ids, the header extension tag MUST be set to 0xC2DE to indicate encryption has been applied, and the two-byte framing is being used.

This text doesn't say what to do if the packet contained a mix of 1 and 2 byte extension-ids. My presumption is that this isn't allowed. I will leave it to the authors to decide whether to clarify this, but acknowledge that it may be obvious to everyone familiar with RTP ...

murillo128 commented 2 years ago

Mix of 1-byte header extensions and 2 byte header extensions is not allowed by rfc8285, but I think that the text is a bit misleading on the draft.