search

jubos / fake-s3

A lightweight server clone of Amazon S3 that simulates most of the commands supported by S3 with minimal dependencies
2.94k stars 355 forks source link

Support buckets with dots in them #235

Closed oggy closed 6 years ago

oggy commented 6 years ago

In the v2 API, DELETE_BUCKET may be performed by passing the bucket name as a subdomain. It appears the presence of dots may invoke this behavior, so handling of the delete bucket operation needed updating here too.

Because the v2 tests now pass the bucket by subdomain, extra subdomains will probably need to be resolved locally via /etc/hosts for the tests to pass. To reduce the number of such domains required, the delete bucket test was updated to use the same bucket as the rest of the tests.

This supersedes #88 and #152.

oggy commented 6 years ago

@jubos Sure, done!

jubos commented 6 years ago

Thanks!