search

jubos / fake-s3

A lightweight server clone of Amazon S3 that simulates most of the commands supported by S3 with minimal dependencies
2.94k stars 355 forks source link

License timebomb should be a major version #239

Closed fcanela closed 6 years ago

fcanela commented 6 years ago

Hello.

A recent change have made license parameter mandatory since september this month. I think that is a breaking change and could cause projects that are not reviewing non-failing logs to suddently shut down. Please, consider rolling back the 1.x branch to one without timebomb and upgrading major version.

pickhardt commented 6 years ago

Sure, we can do that. I'll make the latest 1.x version not have a failure mode, and instead push that to a 2.x major version.

pickhardt commented 6 years ago

Done. Note that a license has been required for over a year and a half, just not enforced in code. So you should still get one. However there's no time bomb as part of the 1.3.1 version. It will be required with the 2.x version after Sep 19.

fcanela commented 6 years ago

Thanks, @pickhardt, for understanding and solving the issue.