Fix Modals cancelled when app is minimised

juce-framework / JUCE

JUCE is an open-source cross-platform C++ application framework for desktop and mobile applications, including VST, VST3, AU, AUv3, LV2 and AAX audio plug-ins.

https://juce.com

Other

6.31k stars 1.67k forks source link

Fix Modals cancelled when app is minimised #1316

Closed quickiwiki closed 5 months ago

quickiwiki commented 6 months ago

This PR resolves issue https://github.com/juce-framework/JUCE/issues/1315

stephenk-az commented 6 months ago

This was the same fix I suggested here (essentially) and attila provided a good reason why this would NOT be the best fix:

https://forum.juce.com/t/bug-minimize-to-dock-on-macos-causes-modal-component-to-lose-modality/57974/5

"The suggested workaround could break existing use-cases. In an application with multiple windows, minimising the one with the modal component would leave the visible window in a non-interactive state, and it would be difficult to discover why this is the case."

szarvas commented 5 months ago

A change has been released on develop

https://github.com/juce-framework/JUCE/commit/fb14118771eeb34f51146e23def0a1f94a49fbad

The minimise and close buttons are now disabled when a component is modal, to avoid this problem the same way Windows does.