search

juce-framework / JUCE

JUCE is an open-source cross-platform C++ application framework for desktop and mobile applications, including VST, VST3, AU, AUv3, LV2 and AAX audio plug-ins.
https://juce.com
Other
6.3k stars 1.67k forks source link

[Bug]: Switch from webkit2gtk 4.0 to 4.1 #1377

Open jbicha opened 2 months ago

jbicha commented 2 months ago

Detailed steps on how to reproduce the bug

webkitgtk introduced the 4.1 API more than a year ago. It is the same as the 4.0 API but uses libsoup3 instead of libsoup2.4. Since JUCE doesn't use libsoup directly, it is an easy swap to switch to the 4.1 API. Every stable Linux distribution with a supported version of webkitgtk already provides the 4.1 packages.

More importantly, Linux distributions have begun removing the 4.0 packages. This is true for Debian Unstable, Ubuntu 24.04 LTS, and probably Fedora 41 (to be released later this year).

What is the expected behaviour?

A command like this can do the switch:

find . -type f -print0 | xargs -0 sed -i '' -e 's/webkit2gtk-4.0/webkit2gtk-4.1/g'

Testing on the develop branch

The bug is present on the develop branch

Code of Conduct

KottV commented 2 weeks ago

It become more reasonable with this commit https://github.com/juce-framework/JUCE/commit/2516ad808efad4ce27ce6070dfe0c4009742356f As I can see we need to set webkit2gtk-4.1 as default in https://github.com/juce-framework/JUCE/blob/61a03097ec9e01693c87ac71935e97b9714cff1a/extras/Build/CMake/JUCEUtils.cmake#L98 and https://github.com/juce-framework/JUCE/blob/61a03097ec9e01693c87ac71935e97b9714cff1a/extras/Projucer/Source/ProjectSaving/jucer_ProjectExporter.cpp#L614

jbicha commented 2 weeks ago

Ok, I'll close the bug now.

KottV commented 2 weeks ago

Ok, I'll close the bug now.

I meant that it's still an issue, and with the mentioned commit things are inconsistent, JUCE partially wants 4.1 and partially 4.0.

tdug commented 1 week ago

@jbicha - I've opened a PR for this.

szarvas commented 1 week ago

We have a fix for this issue shortly coming up.