juce-framework / JUCE

JUCE is an open-source cross-platform C++ application framework for desktop and mobile applications, including VST, VST3, AU, AUv3, LV2 and AAX audio plug-ins.
https://juce.com
Other
6.63k stars 1.74k forks source link

Typo: Rectangle::removeFromBottom Documentation Reports Wrong Result #729

Closed beer-mike closed 4 years ago

beer-mike commented 4 years ago

https://github.com/juce-framework/JUCE/blob/02bbe31c0d2fb59ed32fb725b56ad25536c7ed75/modules/juce_graphics/geometry/juce_Rectangle.h#L527

The documentation for Rectangle::removeFromBottom reports a returned result of (100, 250, 300, 50) for the returned rect but my test shows the actual returned result is (100, 350, 300, 50). The pos.y value of the returned rect is incorrect. I recommend doublechecking these results as I'm fairly tired at the moment. Cheers.

ed95 commented 4 years ago

Good spot! We've corrected this here.