search

judge0 / ide

✨ Simple, free and open-source online code editor.
https://ide.judge0.com
MIT License
818 stars 257 forks source link

Settings Page #7

Closed ron-popov closed 6 years ago

ron-popov commented 6 years ago

A settings page that will contain all of the ide's settings (vim mode toggle, theme selection box, etc ...)

hermanzdosilovic commented 6 years ago

@ron-popov great idea! I think we should wait for these features to be implemented and then you can start working on it.

Instead of settings page, what do you think about placing a toolbar below navbar?

ron-popov commented 6 years ago

I think it will make the page look more crowded , i prefer just placing the button on the current navbar and then moving them to the settings page

hermanzdosilovic commented 6 years ago

I agree, it would look more crowded. I think the most appropriate solution would be to use modals and not special settings page.

ron-popov commented 6 years ago

I will work on this feature.

hermanzdosilovic commented 6 years ago

@ron-popov great! But make sure you have latest master without merge commits. In the last PR i had to rebase your commits :smile: