STOP symbol is added after padding inth decoder data

juditacs / morph-segmentation

Experimenting with supervised morphological segmentation

MIT License

6 stars 5 forks source link

Closed juditacs closed 7 years ago

juditacs commented 7 years ago

This is the current implementation:

padded = ['GO'] + dec + ['PAD' for p in range(self.maxlen_dec - len(dec))] + ['STOP']

I don't want to change it right now because I'm in the middle of debugging https://github.com/juditacs/morph-segmentation/issues/9 but let's not forget it.

BTW this means that even without a STOP symbol, it can learn to stop at a certain point.

juditacs commented 7 years ago

Fixed in the new seq2seq implementation.